Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix weel name using otool #61

Closed
wants to merge 7 commits into from

Conversation

Czaki
Copy link
Contributor

@Czaki Czaki commented Dec 14, 2019

Fixing wheel name with parsing header from python code (based on pypa/wheel#314) and calculate proper platform tag.

  • parsing headers to extract minimal version
  • test of added functions
  • new test for delocate_wheel

@Czaki Czaki force-pushed the weel_name_fix_otool branch 2 times, most recently from 54b62c2 to 85b2c5a Compare April 7, 2020 18:29
@Czaki Czaki force-pushed the weel_name_fix_otool branch from 85b2c5a to 89ac2c2 Compare April 7, 2020 18:54
@Czaki Czaki force-pushed the weel_name_fix_otool branch from 89ac2c2 to ff4fd20 Compare April 7, 2020 19:36
@Czaki
Copy link
Contributor Author

Czaki commented Apr 7, 2020

otool from old xcode does not support LC_BUILD_VERSION

@Czaki Czaki force-pushed the weel_name_fix_otool branch from f28da87 to ca35c93 Compare April 7, 2020 20:15
@HexDecimal
Copy link
Collaborator

Resolved by #198

@HexDecimal HexDecimal closed this Feb 17, 2024
@Czaki Czaki deleted the weel_name_fix_otool branch February 17, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants