Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MM-T847.md to remove unneeded checks for channel order #164

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

lindalumitchell
Copy link
Collaborator

Removed extra info about channel order, which isn't at the core of this test case and depends on config anyway.

Remove extra info about channel order, which isn't the core of this test case and depends on config anyway.
@lindalumitchell lindalumitchell requested a review from lindy65 March 1, 2024 07:12
@lindalumitchell
Copy link
Collaborator Author

lindalumitchell commented Mar 1, 2024

Note that this came out of reviewing RF https://app.rainforestqa.com/runs/1726680/tests/396995/browsers/ios_iphone12_16/steps/315427530, and I'm removing the corresponding verification from RF as well.

I've edited https://app.rainforestqa.com/tests/396995/steps?envId=12644 for iOS to match; @lindy65 is it okay to also edit https://app.rainforestqa.com/tests/396617/steps?envId=12644 for Android to match as well? I'm happy to do that if you agree.

Copy link
Collaborator

@lindy65 lindy65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lindalumitchell - looks good to me 👍

I'll update the Android test to match this PR

@lindalumitchell lindalumitchell merged commit bbc928e into main Mar 1, 2024
1 check failed
@lindalumitchell lindalumitchell deleted the lm-mm-t847 branch March 1, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants