Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: GM to private channel #117

Merged
merged 10 commits into from
Oct 4, 2023
Merged

Feat: GM to private channel #117

merged 10 commits into from
Oct 4, 2023

Conversation

yasserfaraazkhan
Copy link
Collaborator

@yasserfaraazkhan yasserfaraazkhan mentioned this pull request Sep 26, 2023
Merged
saturninoabril
saturninoabril requested changes Sep 27, 2023
View reviewed changes
Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yasserfaraazkhan! LGTM except for few suggestions.

data/test-cases/channels/channel-menu/test-1.md Outdated Show resolved Hide resolved
data/test-cases/channels/channel-menu/test-2.md Outdated Show resolved Hide resolved
data/test-cases/channels/channel-menu/test-2.md Outdated Show resolved Hide resolved
saturninoabril
saturninoabril approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yasserfaraazkhan!

@saturninoabril saturninoabril merged commit 5b449e1 into main Oct 4, 2023
1 check passed
@saturninoabril saturninoabril deleted the gm_convertion_tests branch October 4, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshilsharma63 harshilsharma63 harshilsharma63 approved these changes

@saturninoabril saturninoabril saturninoabril approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yasserfaraazkhan @saturninoabril @harshilsharma63