Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update readme and Gitpod #113

Merged
merged 5 commits into from
Sep 21, 2023
Merged

Update readme and Gitpod #113

merged 5 commits into from
Sep 21, 2023

Conversation

saturninoabril
Copy link
Member

Summary

  • Updated the readme to remove a statement for not being ready to accept contribution and indicate how to mark tests as tested by contributor (mainly at 5e3ca82)
  • Updated GitPod to use latest Deno version
  • Made silverbullet run as optional

@saturninoabril saturninoabril added 2: Dev Review Requires review by a core committer 2: QA Review Requires review by a QA tester labels Sep 20, 2023
lindalumitchell
lindalumitchell approved these changes Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@lindalumitchell lindalumitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Saturn! Just one tiny suggestion. :)

README.md Outdated Show resolved Hide resolved
@saturninoabril @lindalumitchell
apply comment
097fcd6 
Co-authored-by: lindalumitchell <[email protected]>
lindy65
lindy65 approved these changes Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@lindy65 lindy65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @saturninoabril - looks good to me 👍

@lindy65 lindy65 added QA Review Done and removed 2: QA Review Requires review by a QA tester labels Sep 20, 2023
azigler
azigler approved these changes Sep 21, 2023
View reviewed changes
Copy link

@azigler azigler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks @saturninoabril!

@saturninoabril saturninoabril added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Sep 21, 2023
@saturninoabril saturninoabril merged commit d8741d1 into main Sep 21, 2023
1 check passed
@saturninoabril saturninoabril deleted the update-readme-gitpod branch September 21, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lindalumitchell lindalumitchell lindalumitchell approved these changes

@lindy65 lindy65 lindy65 approved these changes

@azigler azigler azigler approved these changes

Assignees
No one assigned
Labels
3: Reviews Complete All reviewers have approved the pull request QA Review Done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saturninoabril @azigler @lindy65 @lindalumitchell