Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MI-3770] Fixed getting improper response in channel when user's account is disconnected #326

Merged
merged 5 commits into from
Dec 12, 2023

Conversation

raghavaggarwal2308
Copy link
Contributor

Summary

When a user tries to create a meeting after disconnecting their account, they get a meeting link in case they have created a meeting recently.

Screenshot:

image

What to test?

  • The user is getting a connection link if they try to create a meeting after he/she has disconnected their account.
Steps to reproduce:
  1. run /zoom connect and connect your account.
  2. run /zoom start OR click the Zoom button in the app bar.
  3. run /zoom disconnect.
  4. run /zoom start OR click the Zoom button in the app bar.

Note: The last two steps must be done within 30 seconds after the second step.

Expected Behaviour:

The user is getting a link to connect his account.

Environment:

MM version: v9.2.2
Node version: 14.18.0
Go version: 1.20.11

Ticket Link

Fixes #306

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (18da1f1) 19.33% compared to head (27150eb) 18.86%.

Files Patch % Lines
server/command.go 0.00% 7 Missing ⚠️
server/http.go 40.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #326      +/-   ##
==========================================
- Coverage   19.33%   18.86%   -0.48%     
==========================================
  Files           9        9              
  Lines        1479     1479              
==========================================
- Hits          286      279       -7     
- Misses       1138     1149      +11     
+ Partials       55       51       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mickmister mickmister added the 3: QA Review Requires review by a QA tester label Nov 28, 2023
Copy link
Contributor

@AayushChaudhary0001 AayushChaudhary0001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and approved, LGTM.

@avas27JTG avas27JTG merged commit 087a6c9 into mattermost:master Dec 12, 2023
11 checks passed
@avas27JTG avas27JTG deleted the MM-306 branch December 12, 2023 14:05
@avas27JTG avas27JTG mentioned this pull request Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: QA Review Requires review by a QA tester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong message when trying to create a meeting after disconnecting
4 participants