Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-51269] Log errors from telemetry events #289

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Conversation

hanzei
Copy link
Collaborator

@hanzei hanzei commented Mar 9, 2023

Summary

Previously errors returned from the telemetry tracker didn't get logged. This PR adds proper log messages for all errors the telemetry tracker returns.

Ticket Link

https://mattermost.atlassian.net/browse/MM-51269

@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Mar 9, 2023
@hanzei hanzei requested a review from m1lt0n March 9, 2023 09:31
@hanzei hanzei requested a review from mickmister as a code owner March 9, 2023 09:31
@hanzei hanzei added this to the v2.0.0 milestone Mar 9, 2023
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c8ef367) 0.00% compared to head (13f4414) 0.00%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #289   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           8       8           
  Lines        1133    1143   +10     
======================================
- Misses       1133    1143   +10     
Impacted Files Coverage Δ
server/telemetry.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Mar 21, 2023
@hanzei hanzei merged commit cb15d74 into master Mar 21, 2023
@hanzei hanzei deleted the MM-51269_telemetry-error branch March 21, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants