Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid using output from failing function #380

Merged
merged 1 commit into from
Jul 29, 2024
Merged

fix: avoid using output from failing function #380

merged 1 commit into from
Jul 29, 2024

Conversation

fmartingr
Copy link
Contributor

Summary

This pull request fixes a crash that was caused when processing the daily summary for an user that couldn't be retrieved. Since we use the output from the LoadUser call in the Warnf call, plugin was crashing.

@fmartingr fmartingr requested a review from wiggin77 as a code owner July 23, 2024 15:01
mgdelacroix
mgdelacroix approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@mgdelacroix mgdelacroix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@wiggin77 wiggin77 merged commit b61c35c into master Jul 29, 2024
6 checks passed
@wiggin77 wiggin77 deleted the fix/error-panic branch July 29, 2024 10:11
@fmartingr fmartingr mentioned this pull request Jul 29, 2024
Merged
@raghavaggarwal2308 raghavaggarwal2308 added this to the v1.3.0 milestone Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiggin77 wiggin77 wiggin77 approved these changes

@mgdelacroix mgdelacroix mgdelacroix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@fmartingr @mgdelacroix @wiggin77 @raghavaggarwal2308