refactor: remove unused commands #349

fmartingr · 2023-12-15T12:05:06Z

Summary

Removed commands not present in documentation: Create calendar, Delete calendar, Find Meetings, Create Event
Moved the show calendars command to admin only, in preparation for when we start working on multiple calendar support.

…tion gcal methods

* remote logic * allow datetimes without timezone * add calendar settings readonly scope to get tz * event conversion * scopes * revert datetime.time

…268) * plugin profile images * receive provider flag * manifests * retrieve manifest id from file * Build time configuration * revert manifest * using go static configuration for providers * removed unused build flags * revert manifest * Added basic Google Calendar instructions * Update providers/GoogleCalendar.md Co-authored-by: Michael Kochell <[email protected]> * Update providers/GoogleCalendar.md Co-authored-by: Michael Kochell <[email protected]> * Update server/plugin/plugin.go Co-authored-by: Michael Kochell <[email protected]> * remoove log --------- Co-authored-by: Michael Kochell <[email protected]>

* user_store: more information fields on the index * feat: endpoint to autocomplete calendar connected users * revert test event store hashed * Update server/api/autocomplete.go Co-authored-by: Michael Kochell <[email protected]> * Update server/api/autocomplete.go Co-authored-by: Michael Kochell <[email protected]> * dont expose private data in endpoint * lint * Update server/store/user_store.go Co-authored-by: Michael Kochell <[email protected]> --------- Co-authored-by: Michael Kochell <[email protected]>

…276) * chore: replace provider display name * chore: replace command trigger references * revert previous changes

…ot supported (#272) * nil control * use subscriptions default ttl * return specific error when no superuser token can be used * notification formatting logic to other file * Client.GetEventsBetweenDates * typo: import * shorter command name :) * availability without super user token * delete store subs only if we successfuly do on remote * comment * ignore missing subs * update sync method * allow switching acting user on the fly * daily summary without super user token * formatted imports * calendar -> calendarEvents * processAllDailySummaryByUser -> processAllDailySummaryWithIndividualCredentials * revert silenced error under notifications * msgraph GetEventsBetweenDates * Update server/mscalendar/daily_summary.go Co-authored-by: Michael Kochell <[email protected]> * [GCAL] Create event logic (#269) * remote logic * allow datetimes without timezone * add calendar settings readonly scope to get tz * event conversion * scopes * revert datetime.time * Client.GetEventsBetweenDates * fix: store last post time * refactored availability logic * availability test * refactored daily summary logic * test: availability * daily summary tests (wip) * daily summary test * fix: merge duplications * slack attachment for notifications * lint and test * goimports * Update server/mscalendar/availability.go Co-authored-by: Michael Kochell <[email protected]> * remove logges * nullify client when changing acting user * move withActiveUser filter to fenced code outside of general method * tests: handling more scenarios * Fixed test after bugfix * fixed test assertions * allow engine copy to perform safe state mutations --------- Co-authored-by: Michael Kochell <[email protected]>

* Added encrypted kvstore * encrypt only oauth2 kv store * retrieve encryption setting from provider config * explicitly disable encrypted store for mscalendar * remove old comment

* feat: added today and tomorrow commands with attachments * remove unused function * linted * now -> day * remove unused code * today/tomorrow autocomplete * return tables on today/tomorrow commands * check for nil location * revert tomorrow day times four * fix markdown table render and test

* fix: test from merges * add meeting url

* Move configuration logic to remotes * check encryption key as well * Update server/plugin/plugin.go Co-authored-by: Michael Kochell <[email protected]> --------- Co-authored-by: Michael Kochell <[email protected]>

* remove batch requests from gcal code * More info in readme

…ssions plus internal state (#282) * fix: notifications scope and acting user logic * remove log * avoid calling notifications if the engine fails to load

* fix: notifications scope and acting user logic * fix: gcal unsubscribe requiring more parameters

* fix: better log information * log missing error

…288) * fix: embed tzdata to prevent errors on systems without it installed * move to main * avoid overwritting location if empty * use tags instead of import

* Optional fields * time picker defaults * Add custom icon to Create Event menu item * add custom icon to date selector * npm run fix * header menu icon multiline * use scss * using proper typeRoots * scoped css style

* extract conference data into new attribute * removed log * removed unused fuunction * tests * Update server/remote/gcal/get_default_calendar_view_test.go Co-authored-by: Michael Kochell <[email protected]> * more realistic datetime values --------- Co-authored-by: Michael Kochell <[email protected]>

* refactor: mscalendar -> engine * remove gcal assets * refactored common code outside server package * check-style * go mod tidy * REPO_URL -> REPOSITORY_URL * delete unknown file * updated mocks

codecov-commenter · 2023-12-15T12:07:29Z

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 22.31%. Comparing base (d1fce7a) to head (4e7a82d).

Files	Patch %	Lines
calendar/command/command.go	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #349      +/-   ##
==========================================
+ Coverage   20.94%   22.31%   +1.36%     
==========================================
  Files          67       63       -4     
  Lines        3442     3231     -211     
==========================================
  Hits          721      721              
+ Misses       2628     2417     -211     
  Partials       93       93

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mickmister

LGTM, thanks for this cleanup 👍

calendar/command/command.go

Co-authored-by: Michael Kochell <[email protected]>

fmartingr · 2023-12-18T13:18:05Z

Added the suggestion and fixed the CI. Blocked until #267 is merged.

raghavaggarwal2308 · 2024-08-09T11:48:37Z

Added the suggestion and fixed the CI. Blocked until #267 is merged.

@fmartingr #267 is merged, can we merge this PR?

fmartingr · 2024-08-09T11:49:28Z

Added the suggestion and fixed the CI. Blocked until #267 is merged.

@fmartingr #267 is merged, can we merge this PR?

Sure, go ahead.

raghavaggarwal2308 · 2024-08-09T17:48:03Z

@wiggin77 @fmartingr Do you think we need a QA on this?

wiggin77 · 2024-08-09T18:22:18Z

@wiggin77 @fmartingr Do you think we need a QA on this?

I don't think so, but Felipe can decide as he is the author.

fmartingr · 2024-08-09T18:40:52Z

@wiggin77 @fmartingr Do you think we need a QA on this?

I don't think we need QA on this, I just removed a bunch of unsupported /non working commands.

mickmister and others added 30 commits December 11, 2020 11:37

oauth works

00e1eb0

autocomplete

742a49c

viewcal works

7f238a2

add unimplemented if blocks

19ff374

Merge branch 'master' into migrate-to-gcal

38ebd1f

fix tests and lint

a88921f

implement CreateMySubscription, RenewSubscription, and DeleteSubscrip…

8259bde

…tion gcal methods

WIP gcal subs

83db731

setup-attach make target

b057dcf

Merge branch 'master' into gcal-merge

863cb37

fix lint and tests

38f3fdf

chore: more compatible tar command

9ed5ee6

add review comments

d78381a

[GCAL] Create event logic (#269)

728630e

* remote logic * allow datetimes without timezone * add calendar settings readonly scope to get tz * event conversion * scopes * revert datetime.time

bug: get timezone from datetime instead of event data (#271)

585e821

[GCAL] Refactor Microsoft Calendar references to provider references (#…

e3d6a94

…276) * chore: replace provider display name * chore: replace command trigger references * revert previous changes

[GCAL] Added encrypted key value storage (#270)

34ca3ed

* Added encrypted kvstore * encrypt only oauth2 kv store * retrieve encryption setting from provider config * explicitly disable encrypted store for mscalendar * remove old comment

[GCAL] Fix test in main branch from PR merges (#277)

f226b5e

* fix: test from merges * add meeting url

[GCAL] Move configuration readyness logic to remotes (#279)

aa14450

* Move configuration logic to remotes * check encryption key as well * Update server/plugin/plugin.go Co-authored-by: Michael Kochell <[email protected]> --------- Co-authored-by: Michael Kochell <[email protected]>

[GCAL] Remove unused code (#278)

d3fe76b

* remove batch requests from gcal code * More info in readme

[GCAL] Fix event notifications not working due to missing scope permi…

b345fef

…ssions plus internal state (#282) * fix: notifications scope and acting user logic * remove log * avoid calling notifications if the engine fails to load

[GCAL] Unsubscriptions (#283)

eba9102

* fix: notifications scope and acting user logic * fix: gcal unsubscribe requiring more parameters

update gcal manifest (#285)

b3f4558

[GCAL] Better logging information (#287)

23a3f23

* fix: better log information * log missing error

use correct manifest file on manifest calls (#290)

95c9a44

[GCAL] Embed tzdata and correctly parse location from event datetime (#…

735fc05

…288) * fix: embed tzdata to prevent errors on systems without it installed * move to main * avoid overwritting location if empty * use tags instead of import

fmartingr and others added 7 commits August 31, 2023 14:27

makefile dist build for production (#314)

8925e67

[GCAL/MSCAL] Create event UX improvements (#309)

dfeb3d1

* Optional fields * time picker defaults * Add custom icon to Create Event menu item * add custom icon to date selector * npm run fix * header menu icon multiline * use scss * using proper typeRoots * scoped css style

Common code refactor, back to mscalendar plugin (#334)

5ef3953

* refactor: mscalendar -> engine * remove gcal assets * refactored common code outside server package * check-style * go mod tidy * REPO_URL -> REPOSITORY_URL * delete unknown file * updated mocks

apped user to handle after all actions (#335)

8b4065b

refactor msgraph to mscalendar

3d0dc0b

refactor: removed unused commands

34980a5

fmartingr self-assigned this Dec 15, 2023

fmartingr requested a review from mickmister as a code owner December 15, 2023 12:05

mickmister approved these changes Dec 15, 2023

View reviewed changes

calendar/command/command.go Outdated Show resolved Hide resolved

fmartingr and others added 2 commits December 18, 2023 14:01

Update calendar/command/command.go

e22422b

Co-authored-by: Michael Kochell <[email protected]>

go mod tidy

f291528

Base automatically changed from migrate-to-gcal to master March 1, 2024 04:02

fmartingr and others added 4 commits April 1, 2024 12:27

Merge remote-tracking branch 'origin/master' into remove-unused-commands

35a8e07

Merge remote-tracking branch 'origin/master' into remove-unused-commands

315c9e2

removed added code from merge

4e7a82d

Merge branch 'master' into remove-unused-commands

04c11ac

raghavaggarwal2308 requested a review from wiggin77 as a code owner August 9, 2024 11:48

raghavaggarwal2308 added this to the v1.3.0 milestone Aug 9, 2024

Merge branch 'master' into remove-unused-commands

ce8cd95

wiggin77 approved these changes Aug 9, 2024

View reviewed changes

raghavaggarwal2308 merged commit 120d1dc into master Aug 9, 2024
6 checks passed

raghavaggarwal2308 deleted the remove-unused-commands branch August 9, 2024 19:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: remove unused commands #349

refactor: remove unused commands #349

fmartingr commented Dec 15, 2023 •

edited

Loading

codecov-commenter commented Dec 15, 2023 •

edited

Loading

mickmister left a comment

fmartingr commented Dec 18, 2023

raghavaggarwal2308 commented Aug 9, 2024

fmartingr commented Aug 9, 2024

raghavaggarwal2308 commented Aug 9, 2024

wiggin77 commented Aug 9, 2024

fmartingr commented Aug 9, 2024

refactor: remove unused commands #349

refactor: remove unused commands #349

Conversation

fmartingr commented Dec 15, 2023 • edited Loading

Summary

codecov-commenter commented Dec 15, 2023 • edited Loading

Codecov Report

mickmister left a comment

Choose a reason for hiding this comment

fmartingr commented Dec 18, 2023

raghavaggarwal2308 commented Aug 9, 2024

fmartingr commented Aug 9, 2024

raghavaggarwal2308 commented Aug 9, 2024

wiggin77 commented Aug 9, 2024

fmartingr commented Aug 9, 2024

fmartingr commented Dec 15, 2023 •

edited

Loading

codecov-commenter commented Dec 15, 2023 •

edited

Loading