feat: use custom component for time of day setting #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmartingr
force-pushed
the
feat/timeofday-custom-component
branch
from
fbf7097 to
26522d3
Compare
fmartingr
force-pushed
the
feat/timeofday-custom-component
branch
from
26522d3 to
4a09178
Compare
|
Hey @mickmister, this is not finished yet, but can you check if what I did in the frontend seems correct? It's working but the console is complaining about a value not being the type is supposed to be with an error. I based it in the work you did with S3. |
|
@fmartingr I'm not seeing this error you're mentioning. Can you post the text or screenshot of the error?
|
Mhmmm that's weird.
|
grundleborg
reviewed
Aug 2, 2024
|
/update-branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.