Surface deactivated users in the search input & E2E fixes #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidkrauser
reviewed
Dec 9, 2024
I had to manually test this change, we don't appear to have any frontend tests and the e2e tests are very raw right now |
BenCookie95
changed the title
BenCookie95
changed the title
wiggin77
approved these changes
Dec 10, 2024
davidkrauser
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Deactivated users were not appearing in the search results. I tested the functionality to see if the actual job works with deactivated users and from what I can tell it's fine. I don't have intimate knowledge of how the plugin works though.
Also fixed the failing e2e tests.
Ticket Link
https://mattermost.atlassian.net/browse/MM-62099