Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E/Test: Add test IDs and update tests #124

Merged
merged 1 commit into from
Dec 2, 2024
Merged

E2E/Test: Add test IDs and update tests #124

merged 1 commit into from
Dec 2, 2024

Conversation

saturninoabril
Copy link
Member

@saturninoabril saturninoabril commented Nov 29, 2024 •
edited
Loading

Summary

  • Added test IDs and aria-labels to easily locate elements
  • Updated LegalHoldPluginPage page and added modal components such as CreateModal and ReleaseModal
  • Added playwright-ui to work with Playwright in UI mode - https://playwright.dev/docs/test-ui-mode
  • Ensure tests are isolated and removed unnecessary numbering in spec filename (initially added to guarantee order)

Screenshot

Screenshot 2024-11-29 at 8 39 15 AM

Ticket Link

none

@saturninoabril saturninoabril added the 2: Dev Review Requires review by a core committer label Nov 29, 2024
wiggin77
wiggin77 approved these changes Nov 30, 2024
View reviewed changes
Copy link
Member

@wiggin77 wiggin77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 👍

@saturninoabril saturninoabril merged commit 5699618 into main Dec 2, 2024
5 checks passed
@saturninoabril saturninoabril deleted the update-e2e-test branch December 2, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiggin77 wiggin77 wiggin77 approved these changes

@fmartingr fmartingr fmartingr approved these changes

Assignees
No one assigned
Labels
2: Dev Review Requires review by a core committer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saturninoabril @fmartingr @wiggin77