-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.0.0 Google Calendar Plugin #41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
50k lines of code is a bit too much to review in one PR. What are the files that I specifically should take a look at?
Code is mostly the same we had in the mscalendar plugin, so the main Not asking for an in-depth review of course, just that what I migrated makes sense, logic was reviewed some time ago. |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #41 +/- ##
=========================================
Coverage ? 11.22%
=========================================
Files ? 16
Lines ? 606
Branches ? 0
=========================================
Hits ? 68
Misses ? 536
Partials ? 2 ☔ View full report in Codecov by Sentry. |
Reusing the same repo as the archived one seems weird, but I saw the discussion on it and I suppose that's the plan we're going with. What was your method of getting the code onto this repo? |
I'd rather go with this without breaking release semver (which we are not) than having a lot of repositores for the same thing. And we are going to have the history anyway. Essentially, I removed all the files and replaced them with the ones from the Google Calendar plugin PoC that I did the other day. |
Adding the |
Summary
This pull request introduces the v1.0.0 Google Calendar release created in the https://github.com/mattermost/mattermost-plugin-mscalendar repository as groundwork for sharing common code for similar plugins.
This PR leverages the work done in that plugin to allow some of the features and allow compatibility with HA environments, check the
README.md
for more details on features.