Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.2.0 #10

Merged
merged 9 commits into from
May 28, 2020
Merged

Release v0.2.0 #10

merged 9 commits into from
May 28, 2020

Conversation

hanzei
Copy link
Contributor

@hanzei hanzei commented May 27, 2020

Summary

  • Update version to v0.2.0

  • Update description and name to be align wording with other plugins

  • Add icon

  • Add metadata
    Screenshot from 2020-05-27 19-34-48

  • Fix urgent bugs

  • Change plugin id to com.matttermost.google-calendar

Ticket Link

Fixes #9

@hanzei hanzei marked this pull request as ready for review May 27, 2020 17:35
@hanzei hanzei added 1: PM Review Requires review by a product manager 2: Dev Review Requires review by a core committer labels May 27, 2020
plugin.json Outdated Show resolved Hide resolved
Copy link
Contributor

@hahmadia hahmadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thumbsup
LGTM! Thanks for the changes. I would just say that ensure whatever changes are made are reflected in the README (in terms of the setup instructions).

plugin.json Outdated Show resolved Hide resolved
@hanzei
Copy link
Contributor Author

hanzei commented May 28, 2020

@levb @hahmadia I did update the plugin id and also the readme. Then I tested if the instructions are working and fixed some urgent issue on that way. Please take another look.

@hanzei hanzei requested review from levb and hahmadia May 28, 2020 08:28
@levb
Copy link

levb commented May 28, 2020

Thanks for the fixes, too!

@levb levb removed the 2: Dev Review Requires review by a core committer label May 28, 2020
@hanzei
Copy link
Contributor Author

hanzei commented May 28, 2020

/update-branch

Copy link
Contributor

@aaronrothschild aaronrothschild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, excited to see this moving forward. Iterate away!

Thanks @hanzei for driving this forward and @hahmadia thanks for your patience, I'm sorry this has taken so long for us to get to this point. As we get more and more cloud customers - they will be more likely to be using Google services than our traditional customers. I'm looking forward to just using it myself on a daily basis :)

@aaronrothschild aaronrothschild removed the 1: PM Review Requires review by a product manager label May 28, 2020
@hanzei hanzei added the 4: Reviews Complete All reviewers have approved the pull request label May 28, 2020
@hanzei hanzei merged commit 51ee6ed into master May 28, 2020
@hanzei hanzei deleted the release_v0.2.0 branch May 28, 2020 19:21
@hanzei
Copy link
Contributor Author

hanzei commented May 28, 2020

@aaronrothschild I did try out the plugin locally and it works quite well. Listing and creating events works like a charm. If you consider this plugin important enough to invest more time, I'm help further enhance it.

@aaronrothschild
Copy link
Contributor

If you consider this plugin important enough to invest more time, I'm help further enhance it.

I was just talking with a customer today who uses Google services. I think we'll get a good reception to this plugin. The big question is if we use the MS Calendar backend to drive this integration as well. cc @levb

@levb
Copy link

levb commented May 28, 2020

That's a bigger question. This plugin is NOT HA ready at the moment; we should IMO release a beta version regardless, and iterate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide an alpha release
5 participants