[MM-945]: Converting user_attribute component and client files to TS #853
+503
−408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kshitij-Katiyar
added
2: Dev Review
wiggin77
approved these changes
Nov 19, 2024
|
@Kshitij-Katiyar @raghavaggarwal2308 it's tough to know if something was missed in a PR like this when no unit tests seem to exist that cover the changes. I'm thinking we should hold off on TS conversions until we have unit test coverage. Thoughts? |
|
@wiggin77 We are just adding types to the existing files and not adding any functionality, so I am not sure how unit tests will be helpful here. |
raghavaggarwal2308
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Converting user_attribute component and client files to TS and other changes"
Actual PR
#785