[MM-36] Update plugin with respect to phase 1 upgrades #727

ayusht2810 · 2023-12-20T11:54:15Z

Summary

Updated plugin with respect to phase 1 upgrades

Updated Makefile
Updated version in nvmrc file and update package-lock.json file.
Updated node-sass to sass
Updated developer docs link in the readme file

Ticket Link

hanzei · 2023-12-20T13:15:29Z

@ayusht2810 Can you please merge master into your PR?

ayusht2810 · 2023-12-20T13:23:11Z

@hanzei I have kept use-branch as my base branch because this PR covers the rest of the plugin upgrades required for Phase 1. The other changes are present in the PR. Let me know your thoughts on it.

codecov-commenter · 2023-12-20T13:24:53Z

Codecov Report

Attention: 81 lines in your changes are missing coverage. Please review.

Comparison is base (44f9c83) 15.85% compared to head (96081af) 15.93%.

Files	Patch %	Lines
build/pluginctl/logs.go	37.39%	72 Missing ⚠️
server/plugin/command.go	0.00%	5 Missing ⚠️
build/pluginctl/main.go	0.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #727      +/-   ##
==========================================
+ Coverage   15.85%   15.93%   +0.08%     
==========================================
  Files          15       17       +2     
  Lines        5778     6018     +240     
==========================================
+ Hits          916      959      +43     
- Misses       4820     5017     +197     
  Partials       42       42

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mickmister · 2023-12-21T16:28:50Z

/update-branch

hanzei

One blocker, otherwise LGTM

Makefile

hanzei · 2024-01-04T12:03:25Z

Let's merge #725 first.

arush-vashishtha

Tested the basic flows and slash commands, everything working fine. Approved.
cc @AayushChaudhary0001

#192) * Revert "Update main.go (#154)" This reverts commit be4a281d0cc791d10e6e5ae917b325b2f054e475. * Revert "[MM-33506] Use embed package to include plugin manifest (#145)" This reverts commit ca9ee3c17c6920a636a33f378e17395afd6f329f. * Revert "Don't generate manifest.ts (#127)" This reverts commit 18d30b50bc7ba800c9f05bfd82970781db0aea3e. * install-go-tools target, adopt gotestsum * bring back make apply + automatic versioning * Update build/manifest/main.go Co-authored-by: Michael Kochell <[email protected]> * suppress git describe error when no tags match * make version/release notes opt-in * fix whitespace in Makefile * document version management options --------- Co-authored-by: Michael Kochell <[email protected]>

Co-authored-by: Jesse Hallam <[email protected]>

…github into MM-36

…ub into MM-36

mickmister · 2024-02-15T04:25:16Z

webapp/src/components/post_menu_action/create_issue/index.js

@@ -16,7 +16,7 @@ const mapStateToProps = (state, ownProps) => {
    const systemMessage = post ? isSystemMessage(post) : true;

    return {
-        show: state[`plugins-${pluginId}`].connected && !systemMessage,
+        show: state[`plugins-${manifest.id}`].connected && !systemMessage,


Not required for this PR, but it would be good to always use a selector for this sort of thing, and never do this plugins-(id) thing in these files. Can this be done as part of the redux store migration?

mickmister · 2024-02-15T04:25:48Z

webapp/src/components/post_menu_actions/attach_comment_to_issue/attach_comment_to_issue.jsx

@@ -26,7 +26,7 @@ export default class AttachCommentToIssuePostMenuAction extends PureComponent {
    };

    connectClick = () => {
-        window.open('/plugins/' + pluginId + '/user/connect', '_blank');
+        window.open('/plugins/' + manifest.id + '/user/connect', '_blank');


This should really be using the server's SiteURL (not needed for this PR)

mickmister · 2024-02-15T04:26:31Z

webapp/src/components/post_menu_actions/attach_comment_to_issue/attach_comment_to_issue.jsx

@@ -4,7 +4,7 @@
 import React, {PureComponent} from 'react';
 import PropTypes from 'prop-types';

-import {id as pluginId} from '../../../manifest';
+import manifest from '../../../manifest';


I see sometimes we import the manifest as 'manifest' and sometimes with the relative path. Probably should just do 'manifest'

hanzei and others added 2 commits December 19, 2023 16:28

Make use of github.com/mattermost/mattermost/server/public

fa151f3

[MM-36] Update plugin with respect to phase 1 upgrades

bfa22ba

ayusht2810 requested a review from hanzei as a code owner December 20, 2023 11:54

ayusht2810 self-assigned this Dec 20, 2023

ayusht2810 requested review from mickmister and raghavaggarwal2308 December 20, 2023 11:54

Merge branch 'master' into use-public

c99cf73

ayusht2810 added the 2: Dev Review Requires review by a core committer label Dec 20, 2023

Merge branch 'use-public' into MM-36

35b1985

mickmister approved these changes Dec 22, 2023

View reviewed changes

ayusht2810 requested a review from AayushChaudhary0001 December 28, 2023 07:50

raghavaggarwal2308 approved these changes Dec 29, 2023

View reviewed changes

Merge branch 'master' into use-public

041e6c6

hanzei requested changes Jan 3, 2024

View reviewed changes

Makefile Outdated Show resolved Hide resolved

[MM-36] Update makefile command for testcases

f9c9049

ayusht2810 requested a review from hanzei January 3, 2024 12:51

hanzei approved these changes Jan 4, 2024

View reviewed changes

hanzei added the Do Not Merge Should not be merged until this label is removed label Jan 4, 2024

arush-vashishtha approved these changes Jan 4, 2024

View reviewed changes

hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Jan 4, 2024

hanzei added this to the v2.3.0 milestone Jan 4, 2024

lieut-data and others added 2 commits February 1, 2024 16:42

Fetch plugin logs from server (#193)

91a10e8

Co-authored-by: Jesse Hallam <[email protected]>

ayusht2810 requested a review from mickmister February 1, 2024 11:20

Merge branch 'use-public' of github.com:mattermost/mattermost-plugin-…

8caf059

…github into MM-36

Base automatically changed from use-public to master February 13, 2024 15:45

ayusht2810 added 2 commits February 14, 2024 14:34

Merge branch 'master' of github.com:mattermost/mattermost-plugin-gith…

b8f7d21

…ub into MM-36

[MM-36] Update plugin.json file

96081af

mickmister approved these changes Feb 15, 2024

View reviewed changes

mickmister merged commit 475c110 into master Feb 15, 2024
8 of 9 checks passed

mickmister deleted the MM-36 branch February 15, 2024 04:27

mattermost-build removed the Do Not Merge Should not be merged until this label is removed label Feb 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MM-36] Update plugin with respect to phase 1 upgrades #727

[MM-36] Update plugin with respect to phase 1 upgrades #727

ayusht2810 commented Dec 20, 2023

hanzei commented Dec 20, 2023

ayusht2810 commented Dec 20, 2023 •

edited

Loading

codecov-commenter commented Dec 20, 2023 •

edited

Loading

mickmister commented Dec 21, 2023

hanzei left a comment

hanzei commented Jan 4, 2024

arush-vashishtha left a comment

mickmister Feb 15, 2024

mickmister Feb 15, 2024

mickmister Feb 15, 2024

[MM-36] Update plugin with respect to phase 1 upgrades #727

[MM-36] Update plugin with respect to phase 1 upgrades #727

Conversation

ayusht2810 commented Dec 20, 2023

Summary

Ticket Link

hanzei commented Dec 20, 2023

ayusht2810 commented Dec 20, 2023 • edited Loading

codecov-commenter commented Dec 20, 2023 • edited Loading

Codecov Report

mickmister commented Dec 21, 2023

hanzei left a comment

Choose a reason for hiding this comment

hanzei commented Jan 4, 2024

arush-vashishtha left a comment

Choose a reason for hiding this comment

mickmister Feb 15, 2024

Choose a reason for hiding this comment

mickmister Feb 15, 2024

Choose a reason for hiding this comment

mickmister Feb 15, 2024

Choose a reason for hiding this comment

ayusht2810 commented Dec 20, 2023 •

edited

Loading

codecov-commenter commented Dec 20, 2023 •

edited

Loading