MM-36587: Enable development #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the result of running go get github.com/mattermost/mattermost-plugin-api@master which in turn ended up upgrading a bunch of the dependencies
agarciamontoro
commented
Jun 21, 2021
Comment on lines
-25
to
+26
| "linux-amd64": "server/dist/plugin-linux-amd64", | ||
| "darwin-amd64": "server/dist/plugin-darwin-amd64", | ||
| "linux-amd64": "server/dist/plugin-linux-amd64", |
There was a problem hiding this comment.
Not sure why this got changed with make apply, but the linter was complaining that I had to run it 🤷
| @@ -1,36 +0,0 @@ | |||
| package main | |||
There was a problem hiding this comment.
Removed this file because this is already tested in the mattermost-plugin-api, so it would be just duplicated code.
crspeller
approved these changes
Jun 21, 2021
cpoile
approved these changes
Jun 22, 2021
agarciamontoro
added
4: Reviews Complete
|
Skipping QA, we have good coverage with the tests, and the core functionality, coming from mattermost-plugin-api, is already being used in Incident Collaboration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Although the README states that this plugin can be used without an E20 license, provided that the
EnableTestingandEnableDevelopersettings are enabled, this was not the case, as the license check passed only when an E20 license was installed.This PR fixes that, by simply using the new
IsE20LicensedOrDevelopmentfunction from mattermost-plugin-api.Ticket Link
https://mattermost.atlassian.net/browse/MM-36587