[MM-62491] Removing exported receivers. #8466
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coltoneshaw
added
the
Build Apps for PR
coltoneshaw
commented
Jan 10, 2025
| + } else { | ||
| + getReactApplicationContext().registerReceiver(foregroundReceiver, filter); | ||
| + getReactApplicationContext().registerReceiver(foregroundReceiver, filter, null, handler, ContextCompat.RECEIVER_NOT_EXPORTED); |
There was a problem hiding this comment.
Build does not like how this is exported. Need to see how to do this for older android versions since the vulnerability report suggested this but it's failing.
> Task :voximplant_react-native-foreground-service:compileReleaseJavaWithJavac FAILED
/home/runner/work/mattermost-mobile/mattermost-mobile/node_modules/@voximplant/react-native-foreground-service/android/src/main/java/com/voximplant/foregroundservice/VIForegroundServiceModule.java:116: error: cannot find symbol
getReactApplicationContext().registerReceiver(foregroundReceiver, filter, null, handler, ContextCompat.RECEIVER_NOT_EXPORTED);
^
symbol: variable handler
location: class VIForegroundServiceModule
/home/runner/work/mattermost-mobile/mattermost-mobile/node_modules/@voximplant/react-native-foreground-service/android/src/main/java/com/voximplant/foregroundservice/VIForegroundServiceModule.java:116: error: cannot find symbol
getReactApplicationContext().registerReceiver(foregroundReceiver, filter, null, handler, ContextCompat.RECEIVER_NOT_EXPORTED);
There was a problem hiding this comment.
The PDF says this line is for Android 12 or lower. Android 12 would be Build.VERSION_CODES.S_V2
Build.VERSION_CODES.O which you specified is Android 8
There was a problem hiding this comment.
Looking back at the code though i think you want >= Build.VERSION_CODES.TIRAMISU (which would be Android 13 and up)
coltoneshaw
added
Build Apps for PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mattermost Calls does not need to have the receiver exported. This is disabling that export and securing the use of these to just the Mattermost app.
Ticket Link
https://mattermost.atlassian.net/browse/MM-62491
Checklist
E2E iOS tests for PR.Device Information
Has not been tested yet, pending an external pipeline where I can test this.
Release Note