Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Use soloader 0.8.0 to fix Android App Bundle & Hermes compatibility. #3539

Closed
wants to merge 1 commit into from

Conversation

raghav-mylagary
Copy link

This PR fixes crash on some Android device when Hermes is enabled facebook/react-native#26759

@raghav-mylagary
Copy link
Author

raghav-mylagary commented Nov 10, 2019

The build failed because the library for adding patch fixes to the dependencies doesn't support multiple patches per package ds300/patch-package#43

@smacgregor
Copy link

smacgregor commented Nov 11, 2019

I believe the soloader version bump is only needed for projects using both Hermes and Android app bundles. It looks like Android is always building to an APK:

https://github.com/mattermost/mattermost-mobile/blob/master/fastlane/Fastfile#L546?

Double checking this patch to react native is needed in order to enable Hermes. (I'm new here so apologies in advance if Mattermost is using Android App Bundles)

@hanzei hanzei requested a review from enahum November 11, 2019 07:08
@hanzei hanzei added the Work In Progress Not yet ready for review label Nov 11, 2019
@enahum
Copy link
Contributor

enahum commented Nov 12, 2019

@raghavyadavm not sure I follow why you say it does not support multi-patches. But in any case we do not build the ReactAndroid target as we use the one provided by RN. And it seems that it was reverted on 0.61.4 facebook/react-native@1b39f67

@enahum
Copy link
Contributor

enahum commented Nov 15, 2019

@raghavyadavm do you think this PR is still valid and if so why?

@raghav-mylagary
Copy link
Author

@enahum SoLoader library below version 0.8.0 had a problem where it loads a 64-bit library instead of the 32-bit library on some devices. This fix was not released in the latest 0.61.x versions because it breaks the Android tests. react-native-community/releases#148 (comment) I am going to close this PR because the build is not successful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Work In Progress Not yet ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants