Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GH action workflow for notifying incoming webhooks on community/hub servers #440

Closed
wants to merge 1 commit into from

Conversation

mickmister
Copy link
Contributor

Summary

This PR uses newly set environment variables with incoming webhooks to send release updates to the community/hub servers.

Ticket Link

Fixes https://mattermost.atlassian.net/browse/CLD-7673

https://hub.mattermost.com/private-core/pl/cdque38knirqpet1soc8x1398e

Copy link
Collaborator

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix 👍

@@ -17,12 +17,12 @@ jobs:
shell: bash
run: |
.github/workflows/notify-mm-blog.sh
- name: Notify channel 1
- name: Notify "Community Configuration" channel on community
uses: mattermost/action-mattermost-notify@master
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we pin the version?

Copy link
Collaborator

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge #441 first

@hanzei hanzei added 2: Dev Review Requires review by a core committer Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) labels Jul 4, 2024
@mickmister
Copy link
Contributor Author

Closing @hanzei

@mickmister mickmister closed this Jul 10, 2024
@mattermost-build mattermost-build removed the Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) label Jul 10, 2024
@hanzei hanzei deleted the notify-channels-env-vars branch August 5, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a core committer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants