Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add v1.0.0 of mattermost-plugin-antivirus to the Marketplace #351

Merged
merged 9 commits into from
May 20, 2023
Merged

Add v1.0.0 of mattermost-plugin-antivirus to the Marketplace #351

merged 9 commits into from
May 20, 2023

Conversation

hanzei
Copy link
Collaborator

@hanzei hanzei commented Mar 28, 2023

@hanzei hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Mar 28, 2023
@hanzei hanzei changed the base branch from master to production March 28, 2023 19:48
@hanzei hanzei force-pushed the add_mattermost-plugin-antivirus_v1.0.0 branch from 3928f69 to cd62e44 Compare March 28, 2023 19:49
@hanzei hanzei removed the 2: Dev Review Requires review by a core committer label Mar 28, 2023
@hanzei
Copy link
Collaborator Author

hanzei commented Apr 11, 2023

@DHaussermann Can we merge this PR?

DHaussermann
DHaussermann approved these changes May 19, 2023
View reviewed changes
Copy link

@DHaussermann DHaussermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and passed

  • I got a working setup for this and did some smoke testing
  • Tested fresh install path
  • Tested upgrade path
  • No change to hostng
  • No change to markerplace icon
  • Version number v1.0.0 correctly showing

LGTM!

@DHaussermann DHaussermann added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels May 19, 2023
@hanzei hanzei merged commit 1f983a9 into production May 20, 2023
@hanzei hanzei deleted the add_mattermost-plugin-antivirus_v1.0.0 branch May 20, 2023 11:15
@hanzei hanzei mentioned this pull request Aug 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHaussermann DHaussermann DHaussermann approved these changes

@mickmister mickmister mickmister approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hanzei @mickmister @DHaussermann