add docker swarm mode support

[pdemagny]

Signed-off-by: Pierre DEMAGNY [email protected]

[xcompass]

Looks good to me. Though I'm never run swarm mode. So I may not be in a good position to review.

[pichouk]

@pdemagny Thanks for your help !

[pichouk]

LGTM, but with few suggestions.
One question : did you test this on a Docker Swarm cluster ? I have no Swarm cluster so I cannot test.

Another thing is that it could be better to add your docker-swarm.yml file under a new /contrib/swarm/ directory on the repository. Usually contribution like this are on a specific folder. Don't forget to modify path on README and volumes also.

[pichouk]

Why not using the mattermost/mattermost-prod-web image ?

[pichouk]

Good point here, but is that necessary to add this to this PR ?

To keep a correct Git history I will prefer to remove this changes from this Pull Request and to open a new one just for this (or if you don't want, I'll do the commit by myself). I will accept directly ;)

[pichouk]

Also, it seems that mattermod bot is not working (@jasonblais ?) and didn't post the comment about Mattermost CLA.
So @pdemagny can you please sign the Mattermost CLA ? More information about this is available on another PR comment #171 (comment)

[jasonblais]

Thanks @pichouk, posted a note about mattermod in the Developers channel: https://pre-release.mattermost.com/core/pl/8k1wnzk6ppb6pmppuocueqt6kc

[pdemagny]

@pichouk Yes ofc i did test it, i wrote it & ran it within a single node swarm with ssl enabled using letsencrypt, tested a few integrations (fabric & jenkins).
I didn't realize there was a mattermost-prod-web image. I'll use it instead of nginx image, which will make the change on docker-entry.sh irrelevant, so i'll remove it. I had other improvements to make anyway, so i'll make the changes later this week or next week.
I'm not a mattermost user/installer normally (which is why i did this, to try it :p), so i'm not familiar with mattermod, but i'll try to look into it too.

[hmhealey]

I'm just going to do my best Mattermod impression here since it's not going to pick up this PR now that it's already open.

---

Thanks for the pull request!

Per the CONTRIBUTING.md file displayed when you created this pull request, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?

This is a standard procedure for many open source projects. Your form should be processed within 24 hours and reviewers for your pull request will be able to proceed.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

[pichouk]

@pdemagny Great ! Ping me when you will need another review :)

For the mattermod stuff, it's just a bot that ask you to sign CLA (like @hmhealey does :) ). I can see that you sign it, so it's good now ;)

[pdemagny]

@pichouk actually, ping ;)

[pdemagny]

Using official image made my modifications to docker-entry.sh irrelevant as expected.
More importantly, using it also made use of docker configs useless too, which means that this stack file is not tied to docker 17.06+ anymore.

[pichouk]

Good for me !

Thanks a lot for this contribution ! 👍 😄