Change package entry for electron-builder. #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably electron-builder has breaking changes for arguments. Please check. |
razzeee
force-pushed
the
electron-builder
branch
3 times, most recently
from
3ad2386 to
fc40305
Compare
|
https://github.com/electron-userland/electron-builder/releases/tag/v4.0.0 seems to be the (first) reason. |
razzeee
force-pushed
the
electron-builder
branch
from
fc40305 to
02c2fc1
Compare
|
It's down to https://github.com/mattermost/desktop/blob/master/package.json#L26
-d seems to now be -t but for some reason platform and arch also don't work |
razzeee
force-pushed
the
electron-builder
branch
from
02c2fc1 to
87da29d
Compare
|
Circle CI is green again |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As #138 (comment) has been fixed, we can reference the head version again.