Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to cimg/go #29

Closed
wants to merge 2 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions plugin-ci/orb.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ orbs:
executors:
default:
docker:
- image: circleci/golang:1.16.0-node
- image: cimg/go:1.16.10-node

commands:
deploy:
Expand All @@ -33,10 +33,10 @@ commands:
default: 1.31.0
gobin:
type: string
default: /go/bin
default: $GOPATH/bin
prefix:
type: string
default: v1
default: v2
description: Prefix for cache key to store the binary.
steps:
- restore_cache:
Expand All @@ -57,10 +57,10 @@ commands:
aliases:
- &restore_cache
restore_cache:
key: go-mod-v1-{{ checksum "go.sum" }}
key: go-mod-v2-{{ checksum "go.sum" }}
- &save_cache
save_cache:
key: go-mod-v1-{{ checksum "go.sum" }}
key: go-mod-v2-{{ checksum "go.sum" }}
paths:
- "/go/pkg/mod"

Expand Down Expand Up @@ -137,7 +137,7 @@ jobs:

deploy-ci:
docker:
- image: circleci/python:2.7
- image: cimg/python:2.7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @hanzei ! Can we move the python image too to 3.X? I think python 2.X is deprecated already.

steps:
- attach_workspace:
at: dist
Expand All @@ -148,7 +148,7 @@ jobs:

deploy-release:
docker:
- image: circleci/python:2.7
- image: cimg/python:2.7
steps:
- attach_workspace:
at: dist
Expand Down