Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-45 - Integrate GolangCI-lint #51

Merged
merged 3 commits into from
Jun 10, 2020
Merged

GH-45 - Integrate GolangCI-lint #51

merged 3 commits into from
Jun 10, 2020

Conversation

nathanaelhoun
Copy link
Contributor

@nathanaelhoun nathanaelhoun commented Jun 8, 2020 •
edited
Loading

Summary

This PR copies most of the golangci-lint configuration from mattermost/mattermost-plugin-starter-template#90 into this repo. This helps with a consistent code style and should improve code quality over time.

Most changes are straightforward and just style wise.

Inspired by mattermost-community/mattermost-plugin-autolink#108.

Ticket Link

Closes #45

@mattermod
Copy link
Contributor

The file Makefile is in the blacklist and should not be modified from external contributors, please if you are part of the Mattermost Org submit this PR in the upstream.
/cc @mattermost/core-security @mattermost/core-build-engineers

@hanzei hanzei linked an issue Jun 8, 2020 that may be closed by this pull request
Integrate GolangCI-Lint #45
Closed
hanzei
hanzei requested changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One request, the rest looks good 👍

server/welcomebot.go Outdated Show resolved Hide resolved
@hanzei hanzei removed the request for review from iomodo June 8, 2020 17:18
@hanzei hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Jun 8, 2020
jfrerich
jfrerich approved these changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@jfrerich jfrerich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @nathanaelhoun!

@hanzei hanzei added this to the v1.3.0 milestone Jun 8, 2020
@mattermod
Copy link
Contributor

The file Makefile is in the blacklist and should not be modified from external contributors, please if you are part of the Mattermost Org submit this PR in the upstream.
/cc @mattermost/core-security @mattermost/core-build-engineers

hanzei
hanzei requested changes Jun 8, 2020
View reviewed changes
server/welcomebot.go Outdated Show resolved Hide resolved
server/welcomebot.go Outdated Show resolved Hide resolved
@mattermod
Copy link
Contributor

The file Makefile is in the blacklist and should not be modified from external contributors, please if you are part of the Mattermost Org submit this PR in the upstream.
/cc @mattermost/core-security @mattermost/core-build-engineers

@hanzei hanzei removed the 2: Dev Review Requires review by a core committer label Jun 8, 2020
@hanzei hanzei requested a review from DHaussermann June 8, 2020 19:17
@hanzei
Copy link
Contributor

hanzei commented Jun 8, 2020

Awesome, thanks @nathanaelhoun 🚀

DHaussermann
DHaussermann approved these changes Jun 9, 2020
View reviewed changes
Copy link

@DHaussermann DHaussermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and passed

  • No issue building
  • I ensured the plugin started and did very brief regression testing
  • Full release testing will be done before we ship the nect release
    LGTM!

Thanks @nathanaelhoun for the PR!

@DHaussermann DHaussermann added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Jun 9, 2020
@hanzei hanzei merged commit c367ba6 into mattermost-community:master Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHaussermann DHaussermann DHaussermann approved these changes

@hanzei hanzei hanzei approved these changes

@jfrerich jfrerich jfrerich approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

Integrate GolangCI-Lint
5 participants
@nathanaelhoun @mattermod @hanzei @jfrerich @DHaussermann