Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue of not being able to add a welcome message in private channel #132

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix issue of not able to add a welcome message in private channel
ayusht2810 committed Apr 18, 2024
commit 1f9919b6ff9cadaa3405f7ac22c9a3a9ac0606a3
2 changes: 1 addition & 1 deletion server/command.go
Original file line number Diff line number Diff line change
@@ -130,7 +130,7 @@ func (p *Plugin) executeCommandSetWelcome(args *model.CommandArgs) {
return
}

if channelInfo.Type == model.ChannelTypePrivate {
if channelInfo.Type == model.ChannelTypeDirect {
p.postCommandResponse(args, "welcome messages are not supported for direct channels")
return
}
2 changes: 1 addition & 1 deletion server/hooks.go
Original file line number Diff line number Diff line change
@@ -39,7 +39,7 @@ func (p *Plugin) UserHasJoinedChannel(c *plugin.Context, channelMember *model.Ch
mlog.Err(appErr),
)
return
} else if channelInfo.Type == model.ChannelTypePrivate {
} else if channelInfo.Type == model.ChannelTypeDirect {
return
}