Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow extra spaces between commands #86

Merged
merged 1 commit into from
Jul 1, 2020
Merged

Allow extra spaces between commands #86

merged 1 commit into from
Jul 1, 2020

Conversation

larkox
Copy link
Contributor

@larkox larkox commented Jun 19, 2020

Summary

Allow extra spaces between commands

Ticket Link

#83

@larkox larkox added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Jun 19, 2020
@larkox larkox requested review from iomodo and jfrerich June 19, 2020 07:52
@codecov-commenter
Copy link

codecov-commenter commented Jun 19, 2020 •
edited
Loading

Codecov Report

Merging #86 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #86   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           8       8           
  Lines         856     858    +2     
======================================
- Misses        856     858    +2
Impacted Files Coverage Δ
server/command.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c70ff0...457fe6a. Read the comment docs.

@hanzei
Copy link
Contributor

hanzei commented Jun 19, 2020

Does this also fix #70?

This was linked to issues Jun 19, 2020
Including white spaces into /todo send crashes the plugin #70
Closed
Plugin does not error gracefully when expecting a username that is not provided #83
Closed
@larkox larkox requested a review from DHaussermann June 22, 2020 08:16
@larkox larkox removed the 2: Dev Review Requires review by a core committer label Jun 22, 2020
DHaussermann
DHaussermann approved these changes Jun 30, 2020
View reviewed changes
Copy link

@DHaussermann DHaussermann left a comment •
edited by hanzei
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and passed

  • Tested that crash does not occur with example in linked ticket
  • Regression tested invalid user sent in the command
  • Tested adding unneeded white space between commands
  • Spot checked other commands

LGTM!

@DHaussermann DHaussermann added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Jun 30, 2020
@hanzei hanzei added this to the v0.3.0 milestone Jul 1, 2020
@larkox larkox merged commit 889ce94 into mattermost-community:master Jul 1, 2020
@larkox larkox mentioned this pull request Jul 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHaussermann DHaussermann DHaussermann approved these changes

@jfrerich jfrerich jfrerich approved these changes

@iomodo iomodo iomodo approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
v0.3.0
6 participants
@larkox @codecov-commenter @hanzei @iomodo @jfrerich @DHaussermann