-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix rudder key #205
fix rudder key #205
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/mattermost/mattermost-plugin-todo/blob/183fb72f1795b992997cfb583e479596dd408b99/plugin.json#L11-L15 need to get updated for the new architecture
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #205 +/- ##
======================================
Coverage 6.87% 6.87%
======================================
Files 10 10
Lines 1600 1600
======================================
Hits 110 110
Misses 1482 1482
Partials 8 8 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving not to block the PR. Not sure if I understand everything that is going on on this PR.
I reverted the changes related to arm64 since they required upgrading to v6 (and it's a blindspot to me). |
Summary
After some name changing, MM_RUDDER_WRITE_KEY has become MM_RUDDER_PLUGINS_PROD.
Fix custom.mk so we get the right data.
Additionally, there were missing architectures so I updated the make server command.I tried to add arm64 architectures but it implies update to mattermost-server/v6 so I removed that from the PR. I kept the refactor for
make server
tho.Ticket Link
no