Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rudder key #205

Merged
merged 3 commits into from
Mar 30, 2023
Merged

fix rudder key #205

merged 3 commits into from
Mar 30, 2023

Conversation

trilopin
Copy link
Contributor

@trilopin trilopin commented Mar 30, 2023

Summary

After some name changing, MM_RUDDER_WRITE_KEY has become MM_RUDDER_PLUGINS_PROD.

Fix custom.mk so we get the right data.

Additionally, there were missing architectures so I updated the make server command.

I tried to add arm64 architectures but it implies update to mattermost-server/v6 so I removed that from the PR. I kept the refactor for make server tho.

Ticket Link

no

@trilopin trilopin requested a review from larkox as a code owner March 30, 2023 11:38
@trilopin trilopin requested a review from hanzei March 30, 2023 11:39
@trilopin trilopin added the 2: Dev Review Requires review by a core committer label Mar 30, 2023
Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (183fb72) 6.87% compared to head (3569494) 6.87%.

❗ Current head 3569494 differs from pull request most recent head 3de1dca. Consider uploading reports for the commit 3de1dca to get more accurate results

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #205   +/-   ##
======================================
  Coverage    6.87%   6.87%           
======================================
  Files          10      10           
  Lines        1600    1600           
======================================
  Hits          110     110           
  Misses       1482    1482           
  Partials        8       8           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@larkox larkox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving not to block the PR. Not sure if I understand everything that is going on on this PR.

@trilopin trilopin requested a review from hanzei March 30, 2023 13:44
@trilopin trilopin changed the title fix rudder key and add missing architectures fix rudder key Mar 30, 2023
@trilopin
Copy link
Contributor Author

I reverted the changes related to arm64 since they required upgrading to v6 (and it's a blindspot to me).

@trilopin trilopin merged commit 0c4dbfb into master Mar 30, 2023
@trilopin trilopin deleted the new_secret_rudder branch March 30, 2023 14:56
@trilopin trilopin added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Mar 30, 2023
@Kshitij-Katiyar Kshitij-Katiyar mentioned this pull request Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants