Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating todo UI fixes #189

Merged
merged 2 commits into from
Sep 12, 2022
Merged

Updating todo UI fixes #189

merged 2 commits into from
Sep 12, 2022

Conversation

asaadmahmood
Copy link
Contributor

Summary

Updating todo UI fixes

Ticket Link

Fixes #187
Fixes #186

@asaadmahmood asaadmahmood requested a review from larkox as a code owner September 7, 2022 07:50
@asaadmahmood asaadmahmood added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Sep 7, 2022
@DHaussermann
Copy link

/update-branch

DHaussermann
DHaussermann approved these changes Sep 7, 2022
View reviewed changes
Copy link

@DHaussermann DHaussermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and passed

  • Won't Do button styling looks consistent
  • Mark as Done no longer breaks and is functioning as expected

LGTM!

@DHaussermann DHaussermann added QA Review Done PR has been approved by QA and removed 3: QA Review Requires review by a QA tester labels Sep 7, 2022
@mickmister mickmister merged commit 18a628a into master Sep 12, 2022
@mickmister mickmister deleted the ui-fixes branch September 12, 2022 15:19
@mickmister mickmister mentioned this pull request Sep 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHaussermann DHaussermann DHaussermann approved these changes

@mickmister mickmister mickmister approved these changes

@larkox larkox larkox approved these changes

Assignees
No one assigned
Labels
2: Dev Review Requires review by a core committer QA Review Done PR has been approved by QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ToDos can no longer be marked as Done from the bump post UI looks very unpolished in the Bump post
5 participants
@asaadmahmood @DHaussermann @larkox @mickmister @mattermod