Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm install --verbose to avoid CircleCI timeout #170

Merged
merged 1 commit into from
Jun 3, 2022

Conversation

mickmister
Copy link
Contributor

Summary

There is currently an issue with plugin projects, where CI will timeout during npm install. There is an issue with fetching dependencies from GitHub, which is causing this step to take longer than usual. Since CircleCI times out after 10 minutes of no console output, this is causing CI to fail for all webapp plugins.

This PR makes it so use the --verbose flag, so the command will have intermediate output, making it so CircleCI does not cancel the build. There is another suggested solution of editing the git config with git config --global url."ssh://git@".insteadOf git://, but we have decided to go with the --verbose approach instead.

More context here:
https://community-daily.mattermost.com/core/pl/ckmtk65jqjr6p8ahmrk9ggu1gh
https://community-daily.mattermost.com/core/pl/h3gdpbm5gpdai8xxmk1jc4k3ro

Ticket Link

Fixes https://mattermost.atlassian.net/browse/MM-44776

@mickmister mickmister requested a review from agarciamontoro June 2, 2022 18:11
@mickmister mickmister requested a review from larkox as a code owner June 2, 2022 18:11
Copy link

@agarciamontoro agarciamontoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mickmister <3

@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2022

Codecov Report

Merging #170 (18708e3) into master (42e4f42) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #170   +/-   ##
======================================
  Coverage    8.42%   8.42%           
======================================
  Files          10      10           
  Lines        1152    1152           
======================================
  Hits           97      97           
  Misses       1047    1047           
  Partials        8       8           
Impacted Files Coverage Δ
server/manifest.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fffb1d6...18708e3. Read the comment docs.

@agarciamontoro agarciamontoro added the 4: Reviews Complete All reviewers have approved the pull request label Jun 3, 2022
@agarciamontoro agarciamontoro merged commit 48f19ec into master Jun 3, 2022
@agarciamontoro agarciamontoro deleted the npm-install-verbose branch June 3, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants