-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix plugin visuals to handle different themes #116
Fix plugin visuals to handle different themes #116
Conversation
Codecov Report
@@ Coverage Diff @@
## master #116 +/- ##
======================================
Coverage 3.97% 3.97%
======================================
Files 9 9
Lines 930 930
======================================
Hits 37 37
Misses 893 893 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job, @colorfusion ! Thank you very much.
LGMT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@colorfusion We only use theme variables in the multiples of 4.
You can see the variables available in the utils file of the webapp: |
I've adjusted the theme variables to be in multiple of 4, and fixed the input box's border with new screenshots in the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and passed
- Tabs now look like tabs and not buttons
- Typeface color on unselected tab now has more contrast on darker themes to be more readable
- Tested all themes
- Color scheme of To Do seems consistent with other UI elements when theme is applied
- No issues found
LGTM!
Huge thanks @colorfusion for implementing this! Your changes have hugely improved the UI for this plugin. Much appreciated.
Summary
This pull request will adjust the visuals of the plugin, allowing the plugin to adapt to different themes in the application accordingly.
The style has been adjusted slightly to differentiate the different components in the plugin, and to follow Mattermost's layout more closely.
Ticket Link
Fixes #78
Screenshot
Sidebar
Add / Request Todo (root page)
Todo Message Input