-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement on texts and error behaviours on /todo settings #110
Improvement on texts and error behaviours on /todo settings #110
Conversation
@larkox Can we format the Invalid input on/off like we did above? (in code blocks). |
Also, we need a full stop after the end of each error. |
Codecov Report
@@ Coverage Diff @@
## master #110 +/- ##
=========================================
- Coverage 3.77% 3.75% -0.03%
=========================================
Files 8 8
Lines 928 933 +5
=========================================
Hits 35 35
- Misses 893 897 +4
- Partials 0 1 +1
Continue to review full report at Codecov.
|
@asaadmahmood Sure. Here is a screenshot with the on/off corrected, and a few with the full stop at the end of the sentence. |
@larkox |
@asaadmahmood We are limited by markdown here. If I remember correctly, there is no markdown to change the color of the text (but would be a nice addition! (as long we keep it to a limited set of colors like error, warning, etc...)). We could go with Message Attachments, and change the color of the bar on the left, but since we the code is in back-end, I am not sure we can access the theme color for error. Edit: We can also go with custom post types, but then they will not work on mobile... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can go with what we have for now then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two questions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@hanzei or @jfrerich If you have a bit of time, could one of you peer-test this PR using the peer testing process documented here https://mattermost.atlassian.net/wiki/spaces/INT/pages/619937892/Peer+Testing+Process |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and passed
Based on code changes, I have reviewed improved error messages shown to the user. No issues found
LGTM!
No changes needed to release testing.
Summary
Improve the texts and error messages/behaviours on /todo settings
Current look:
/todo settings
/todo settings summ
/todo settings summary
/todo settings summary on
/todo settings summary off
/todo settings summary foo
/todo settings summary on foo
Ticket Link
None