Render correctly linebreaks #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larkox
added
2: Dev Review
Codecov Report
@@ Coverage Diff @@
## master #108 +/- ##
======================================
Coverage 3.97% 3.97%
======================================
Files 9 9
Lines 930 930
======================================
Hits 37 37
Misses 893 893 Continue to review full report at Codecov.
|
|
I would like to hear feedback from UX on this. Also, @asaadmahmood is much more suited to review CSS code. |
jfrerich
approved these changes
Jul 27, 2020
larkox
removed
1: UX Review
DHaussermann
approved these changes
Aug 13, 2020
DHaussermann
added
4: Reviews Complete
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I copied most of the relevant styles on the posts on the webapp to render all the elements as they are in posts, solving the problem with line breaks.
The problem with line breaks is that the text:
was rendered as:
something some other lineTicket Link
None