Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change channel header button to toggle RHS #106

Merged
merged 2 commits into from
Aug 4, 2020
Merged

Change channel header button to toggle RHS #106

merged 2 commits into from
Aug 4, 2020

Conversation

colorfusion
Copy link
Contributor

Summary

This pull request will change the channel header button behavior to toggle RHS instead of showing.

Ticket Link

#97

@colorfusion colorfusion requested a review from larkox as a code owner July 26, 2020 06:49
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2020 •
edited
Loading

Codecov Report

Merging #106 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #106   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           8       8           
  Lines         858     858           
======================================
  Misses        858     858

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e146a1...77c7492. Read the comment docs.

@hanzei hanzei linked an issue Jul 26, 2020 that may be closed by this pull request
Make the channel header button toggle RHS instead of just show #97
Closed
@hanzei hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Jul 26, 2020
larkox
larkox approved these changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@larkox larkox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution! 🎉

@larkox larkox requested a review from levb July 27, 2020 11:36
@levb levb removed the 2: Dev Review Requires review by a core committer label Jul 27, 2020
@levb levb requested a review from DHaussermann July 27, 2020 13:04
DHaussermann
DHaussermann approved these changes Aug 3, 2020
View reviewed changes
Copy link

@DHaussermann DHaussermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and passed

  • Confirmed toggle works in on and off state
  • Ensured it works as expected in normal and expanded width
  • Ensure that when changing RHS content changes while to do is open (using search for example) toggle correctly moves to off state
  • Tested on Browser and Desktop
    LGTM!

Thanks @colorfusion for this enhancement!

@DHaussermann DHaussermann added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Aug 3, 2020
@larkox larkox merged commit 1905ad5 into mattermost-community:master Aug 4, 2020
@colorfusion colorfusion deleted the feature/channel-header-toggle branch August 4, 2020 12:31
@larkox larkox mentioned this pull request Sep 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHaussermann DHaussermann DHaussermann approved these changes

@larkox larkox larkox approved these changes

@levb levb levb approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the channel header button toggle RHS instead of just show
6 participants
@colorfusion @codecov-commenter @levb @larkox @DHaussermann @hanzei