Posting response when there are no Todos to pop instead of unkown error #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanzei
added
2: Dev Review
larkox
approved these changes
Jul 27, 2020
hanzei
approved these changes
Jul 27, 2020
| @@ -216,6 +216,10 @@ func (p *Plugin) runListCommand(args []string, extra *model.CommandArgs) (bool, | |||
| func (p *Plugin) runPopCommand(args []string, extra *model.CommandArgs) (bool, error) { | |||
| issue, foreignID, err := p.listManager.PopIssue(extra.UserId) | |||
| if err != nil { | |||
| if err.Error() == "cannot find issue" { | |||
There was a problem hiding this comment.
The idiomatic way would be to define an error type e.g. ItemNotFound and check for it here using error.Is.
|
@DHaussermann Mind skipping QA review as this is a beta plugin? |
DHaussermann
approved these changes
Jul 29, 2020
There was a problem hiding this comment.
Yes @hanzei this would be fine to merge.
Reviewed code change and added an explicit test for this to release testing. This will be covered on the next version bump PR.
LGTM!
Thanks @dantepippi fir fixing this!
DHaussermann
added
4: Reviews Complete
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue 92 posting a response message when there are no Todos to pop instead of unkown error.
closes #92