Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync with starter template #103

Merged
merged 10 commits into from
Aug 10, 2020
Merged

Sync with starter template #103

merged 10 commits into from
Aug 10, 2020

Conversation

mickmister
Copy link
Contributor

Summary

Most of this PR was generated using the repository sync tool. It worked really well. I've committed the modified build/sync/plan.yml used for the migration to this repo.

There is also a commit containing work from an open PR in the starter template: Use socket API to deploy plugins

Ticket Link

Fixes #102

@mickmister mickmister added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Jul 23, 2020
@mickmister mickmister requested review from lieut-data and hanzei July 23, 2020 06:40
@mickmister mickmister requested a review from larkox as a code owner July 23, 2020 06:40
larkox
larkox approved these changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@larkox larkox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart of the linting errors, LGTM.

lieut-data
lieut-data approved these changes Jul 23, 2020
View reviewed changes
build/sync/plan.yml Outdated Show resolved Hide resolved
@mickmister mickmister mentioned this pull request Jul 29, 2020
Merged
hanzei
hanzei requested changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of the sync 👍

.circleci/config.yml Outdated Show resolved Hide resolved
@hanzei
Copy link
Contributor

hanzei commented Jul 30, 2020

@mickmister FYI CI is failing with https://app.circleci.com/pipelines/github/mattermost/mattermost-plugin-todo/195/workflows/da40aa81-8971-4248-9a24-3776c14cedec/jobs/545/parallel-runs/0/steps/0-106

@mickmister mickmister requested a review from hanzei July 31, 2020 11:01
hanzei
hanzei approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🚀

@hanzei hanzei removed the 2: Dev Review Requires review by a core committer label Jul 31, 2020
@hanzei hanzei added this to the v0.4.0 milestone Jul 31, 2020
@mickmister mickmister requested a review from DHaussermann August 7, 2020 17:34
DHaussermann
DHaussermann approved these changes Aug 10, 2020
View reviewed changes
Copy link

@DHaussermann DHaussermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and passed

  • Built and deployed without issue
  • Regression tested adding, sending, completing, canceling etc...
  • Regression tested that appropriate DMs are sent via thebot
  • Regression tested slassh commands
    LGTM!

@DHaussermann DHaussermann added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Aug 10, 2020
@larkox
Copy link
Contributor

larkox commented Aug 10, 2020

@mickmister heads up that there are merge conflicts on this PR.

@hanzei hanzei added the Awaiting Submitter Action Blocked on the author label Aug 10, 2020
@mickmister mickmister removed the Awaiting Submitter Action Blocked on the author label Aug 10, 2020
@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2020 •
edited
Loading

Codecov Report

Merging #103 into master will increase coverage by 0.20%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #103      +/-   ##
=========================================
+ Coverage    3.77%   3.97%   +0.20%     
=========================================
  Files           8       9       +1     
  Lines         928     930       +2     
=========================================
+ Hits           35      37       +2     
  Misses        893     893
Impacted Files Coverage Δ
server/manifest.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1905ad5...070fa08. Read the comment docs.

@mickmister mickmister merged commit cd547b1 into master Aug 10, 2020
@mickmister mickmister deleted the sync-starter-template branch August 10, 2020 15:17
@larkox larkox mentioned this pull request Sep 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHaussermann DHaussermann DHaussermann approved these changes

@hanzei hanzei hanzei approved these changes

@larkox larkox larkox approved these changes

@lieut-data lieut-data lieut-data approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.

Sync with starter template
6 participants
@mickmister @hanzei @larkox @codecov-commenter @lieut-data @DHaussermann