Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a ToDo from a post does not move the [Permalink] #177

Closed
DHaussermann opened this issue Aug 25, 2022 · 2 comments · Fixed by #180
Closed

Adding a ToDo from a post does not move the [Permalink] #177

DHaussermann opened this issue Aug 25, 2022 · 2 comments · Fixed by #180
Assignees
@asaadmahmood
Labels
Type/Bug Something isn't working

Comments

@DHaussermann
Copy link

Previously when creating a To Do from a Mattermost post the [Permalink] is moved to a new line below the quoted text.
Now there is no white space and the link is immediately after the text.
image

This screen shows the previous and current behavior side by side.
image
image

The issue is especially bothersome because trying to use the enter or return key to add the line break yourself will save the data. 0/5 of this is desirable once the bug is fixed.
@DHaussermann DHaussermann added Triage Type/Bug Something isn't working labels Aug 25, 2022
@catalintomai
Copy link

Looks to be a regression; need to fix this before marketplace release.Thanks!

asaadmahmood added a commit that referenced this issue Aug 30, 2022
@asaadmahmood
GH-177 - Minor UI tweaks and regression fix
4755b0c
@asaadmahmood asaadmahmood mentioned this issue Aug 30, 2022
Merged
@asaadmahmood
Copy link
Contributor

@catalintomai Submitted a PR with a fix.

asaadmahmood added a commit that referenced this issue Sep 1, 2022
@asaadmahmood
GH-177 - Minor UI tweaks and regression fix (#180)
7b7bece 
* GH-177 - Minor UI tweaks and regression fix

* Updating keyboard shortcut to allow shift

* Updating todo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asaadmahmood asaadmahmood

Labels
Type/Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-177 - Minor UI tweaks and regression fix mattermost-community/mattermost-plugin-todo
3 participants
@asaadmahmood @DHaussermann @catalintomai