Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Focus stays in the main window when assignment modal is opened #173

Closed
DHaussermann opened this issue Aug 10, 2022 · 3 comments
Closed

Focus stays in the main window when assignment modal is opened #173

DHaussermann opened this issue Aug 10, 2022 · 3 comments
Labels
Type/Bug Something isn't working
Milestone
v0.7.0

Comments

@DHaussermann
Copy link

When I open the modal to assign a To Do to someone, the focus does not move.
When I type to search for a user the search does not respond and if i hit the D keystroke (or any other shortcut) I can see that I'm manipulating the data in the Todo list behind the modal.

Steps:

  • Create a ToDo not assigned to anyone
  • Click to assign the ToDO
  • Without touching the mouse to manually move the focus type D to search for Dylan
    Observed Search does not have the focus and I can see that I've deleted my ToDo that the assign modal is open for
@DHaussermann DHaussermann added Triage Type/Bug Something isn't working labels Aug 10, 2022
@DHaussermann DHaussermann mentioned this issue Aug 10, 2022
Merged
@catalintomai catalintomai moved this to Code Changed Needed in Integration Releases Aug 22, 2022
@catalintomai catalintomai added this to the v0.6.0 milestone Aug 22, 2022
@mickmister
Copy link
Contributor

@asaadmahmood Would you happen to know of a quick/proper fix for this issue? It seems it was introduced in your PR here #161

@asaadmahmood
Copy link
Contributor

asaadmahmood commented Aug 22, 2022 •
edited
Loading

@mickmister Not sure of a proper fix, but a quick fix would be to close the menu when the assign event is fired.
I can't repro this if you click on the assign menu item, but when you use the shortcut a to open the assign modal, then this issue occurs because when opening the menu with the shortcut, the menu doesn't close.

@DHaussermann Are you sure this repros when you click on the assign option, or only when you use the shortcut (a) to open assign modal?

I've submitted a fix on the shortcut.

asaadmahmood added a commit that referenced this issue Aug 22, 2022
@asaadmahmood
GH-173 - Assign modal fix
f2f6dbc
@asaadmahmood asaadmahmood mentioned this issue Aug 22, 2022
Merged
asaadmahmood added a commit that referenced this issue Aug 25, 2022
@asaadmahmood @larkox @mickmister
GH-173 - Assign modal fix (#174)
05b224a 
* GH-173 - Assign modal fix

* Update webapp/src/widget/menuItem.tsx

Co-authored-by: Daniel Espino García <[email protected]>

* Update webapp/src/components/user_selector/autocomplete_selector.tsx

Co-authored-by: Michael Kochell <[email protected]>

* Updating menu item

* Updating menu item

Co-authored-by: Daniel Espino García <[email protected]>
Co-authored-by: Michael Kochell <[email protected]>
@mickmister mickmister mentioned this issue Aug 25, 2022
Closed
@catalintomai catalintomai modified the milestones: v0.6.0, v0.7.0 Sep 12, 2022
@mickmister
Copy link
Contributor

Fixed with #174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type/Bug Something isn't working
Projects
None yet
Milestone
v0.7.0
Development

No branches or pull requests
4 participants
@mickmister @asaadmahmood @DHaussermann @catalintomai