Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Golang CI integration, linter fixes #40

Merged
merged 4 commits into from
Aug 5, 2020
Merged

Golang CI integration, linter fixes #40

merged 4 commits into from
Aug 5, 2020

Conversation

AugustasV
Copy link
Contributor

Summary

Added golang lint CI files, fixed some linter errors.

Pull request Link

Fixes #39

@AugustasV AugustasV requested a review from levb as a code owner August 3, 2020 16:59
@mattermod
Copy link

The file Makefile is in the blocklist and should not be modified from external contributors, please if you are part of the Mattermost Org submit this PR in the upstream.
/cc @mattermost/core-security @mattermost/core-build-engineers

@hanzei
Copy link
Contributor

hanzei commented Aug 3, 2020

/update-branch

@mattermod
Copy link

The file Makefile is in the blocklist and should not be modified from external contributors, please if you are part of the Mattermost Org submit this PR in the upstream.
/cc @mattermost/core-security @mattermost/core-build-engineers

@hanzei hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Aug 3, 2020
hanzei
hanzei requested changes Aug 3, 2020
View reviewed changes
Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! A few comments on Makefile. Let me know if you need help with that file.

build/custom.mk Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@mattermod
Copy link

The file Makefile is in the blocklist and should not be modified from external contributors, please if you are part of the Mattermost Org submit this PR in the upstream.
/cc @mattermost/core-security @mattermost/core-build-engineers

@AugustasV
Copy link
Contributor Author

@hanzei tried to compare old Makefile and merge the missing pieces to the new one.
Waiting for comments, not sure I didn't reuse too much old code.

levb
levb approved these changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@levb levb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks, @AugustasV

@levb levb removed the 3: QA Review Requires review by a QA tester label Aug 4, 2020
@mattermod
Copy link

The file Makefile is in the blocklist and should not be modified from external contributors, please if you are part of the Mattermost Org submit this PR in the upstream.
/cc @mattermost/core-security @mattermost/core-build-engineers

@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Aug 5, 2020
@hanzei hanzei added this to the v0.1 - community milestone Aug 5, 2020
@hanzei hanzei merged commit dc5778d into mattermost-community:master Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanzei hanzei hanzei approved these changes

@levb levb levb approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
v0.1 - community
Development

Successfully merging this pull request may close these issues.

Integrate GolangCI-Lint
4 participants
@AugustasV @mattermod @hanzei @levb