Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Perform changes related to CI/CD. Prepare plugin for community migration. #244

Merged
merged 3 commits into from
Apr 18, 2024
Merged

feat: Perform changes related to CI/CD. Prepare plugin for community migration. #244

merged 3 commits into from
Apr 18, 2024

Conversation

toninis
Copy link
Contributor

@toninis toninis commented Apr 11, 2024

Summary

  • Remove scheduled ci workflow and upgrade plugin-ci reusable workflow
  • Do not execute ci tasks upon tag creation
  • Remove cd trigger upon workflow run event. Keep it simple upon tag creation.

Related PRs

mattermost/actions#22
mattermost/actions-workflows#40

Ticket Link

https://mattermost.atlassian.net/browse/CLD-7458

@toninis toninis requested a review from larkox as a code owner April 11, 2024 10:09
@toninis toninis requested a review from hanzei April 11, 2024 10:09
larkox
larkox approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@larkox larkox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any issue, but I this is way out of my comfort zone. Since I am a code owner for this repo, I will approve to unblock this, but this could use a second review from someone more familiar with these actions.

hanzei
hanzei requested changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking on mattermost/actions-workflows#40 (comment)

@hanzei hanzei added the 4: Reviews Complete All reviewers have approved the pull request label Apr 18, 2024
@hanzei hanzei merged commit cc21338 into master Apr 18, 2024
@hanzei hanzei deleted the feat/prepare-plugin-for-community-migration branch April 18, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanzei hanzei hanzei approved these changes

@larkox larkox larkox approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@toninis @larkox @hanzei