Use ReactDOM webpack external #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 45.47% // Head: 45.47% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #224 +/- ##
=======================================
Coverage 45.47% 45.47%
=======================================
Files 7 7
Lines 873 873
=======================================
Hits 397 397
Misses 451 451
Partials 25 25 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
larkox
approved these changes
Sep 29, 2022
mickmister
added a commit
that referenced
this pull request
Oct 28, 2022
mickmister
added a commit
that referenced
this pull request
Nov 3, 2022
* react-dom_webpack-external (#224) * bump version 2.0.1 * MM-40214: Add App Bar icon (#214) * go get -u golang.org/x/sys * Fix CI * Add App Bar icon * Fix errors found by linter * Allow arrow functions in eslint's func-style rule * fix type mismatch at redux Provider Co-authored-by: Ngoan Tran <[email protected]> * go mod tidy * remove npm i --verbose * Fix linter errors (#227) * lint Co-authored-by: Alejandro García Montoro <[email protected]> Co-authored-by: Ngoan Tran <[email protected]> Co-authored-by: Ben Schumacher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This plugin currently doesn't use
react-domorreact-select, so nothing should have broken here. One of these libraries may be used in the future.Ticket Link
Fixes https://mattermost.atlassian.net/browse/MM-47046