GH-30 initial integration of golangci-lint

[hectorgabucio]

Summary

Integrates GolangCI-Lint in mattermost jenkins plugin.

Ticket Link

Fixes #30

[mattermod]

Hello @hectorgabucio,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

[codecov-io]

Codecov Report

Merging #44 into master will decrease coverage by 0.02%.
The diff coverage is 3.33%.

@@            Coverage Diff            @@
##           master     #44      +/-   ##
=========================================
- Coverage    5.82%   5.80%   -0.03%     
=========================================
  Files           6       6              
  Lines         738     741       +3     
=========================================
  Hits           43      43              
- Misses        677     680       +3     
  Partials       18      18              

Impacted Files	Coverage Δ
server/api.go	0.00% <0.00%> (ø)
server/command.go	0.00% <0.00%> (ø)
server/configuration.go	25.00% <0.00%> (ø)
server/plugin.go	4.24% <0.00%> (-0.03%)	⬇️
server/utils.go	43.13% <33.33%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20876f8...6f5a9b8. Read the comment docs.

[hanzei]

Thanks for the contribution 👍

Plugins use p.API.Log* instead of log. See https://developers.mattermost.com/extend/plugins/server/reference/#API.LogWarn for the docs. Would you please change that?

[hanzei]

One nit pick, the rest looks good 👍

[hanzei]

Great work 🎉

[hanzei]

@hectorgabucio Could you please resolve the merge conflict?

[mickmister]

Awesome work @hectorgabucio!

[hectorgabucio]

@hanzei the linting failed https://app.circleci.com/pipelines/github/mattermost/mattermost-plugin-jenkins/75/workflows/be714750-99de-48fe-927c-f340a226f6ca/jobs/246 maybe we use a newer golang ci version in CI?

[hectorgabucio]

@hanzei @mickmister conflicts resolved and CI passed

[hanzei]

Awesome, thanks @hectorgabucio 👍

@DHaussermann There are no function changes in this PR. I've successfully build and deployed the plugin locally. Any additional tests you want to make?

[DHaussermann]

Tested and passed

• Built from this branch - no lint issues with full make
• Enabled the plugin and tested that slash commands seem functional
• I will this during end to end testing before the next release for a thorough regression test

LGTM!
Thanks @hectorgabucio for this enhancement!

[mattermod]

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

[jasonblais]

cc @mickmister @hanzei please help with merging if Automerge label is unsuccessful.

[mattermod]

Trying to auto merge this PR.

[mattermod]

Pull Request successfully merged
SHA: 75a7f7d