Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GH-32] Add command autocomplete #43

Merged
merged 5 commits into from
Oct 16, 2020
Merged

[GH-32] Add command autocomplete #43

merged 5 commits into from
Oct 16, 2020

Conversation

nathanaelhoun
Copy link
Contributor

@nathanaelhoun nathanaelhoun commented Oct 5, 2020 •
edited
Loading

Summary

  • Add slash command autocomplete
    Peek 2020-10-05 23-30
    (the commands are now in alphabetical order in the list)

Ticket Link

Closes #32

@mattermod
Copy link

Hello @nathanaelhoun,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@jasonblais jasonblais added 1: PM Review Requires review by a product manager 2: Dev Review Requires review by a core committer labels Oct 5, 2020
aaronrothschild
aaronrothschild approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@aaronrothschild aaronrothschild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @nathanaelhoun thanks for your contribution - this will certainly make the command easier to use!

@jasonblais jasonblais added 3: QA Review Requires review by a QA tester hacktoberfest-accepted labels Oct 6, 2020
@jasonblais jasonblais requested review from iomodo and removed request for hanzei October 6, 2020 20:45
mickmister
mickmister requested changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@mickmister mickmister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @nathanaelhoun! I have a few requests regarding grammar, and a request for alphabetizing the commands.

server/command.go Outdated Show resolved Hide resolved
server/command.go Outdated Show resolved Hide resolved
server/command.go Outdated Show resolved Hide resolved
server/command.go Outdated Show resolved Hide resolved
server/command.go Outdated Show resolved Hide resolved
server/command.go Outdated Show resolved Hide resolved
server/command.go Outdated Show resolved Hide resolved
server/command.go Outdated Show resolved Hide resolved
server/command.go Outdated Show resolved Hide resolved
server/command.go Outdated Show resolved Hide resolved
@codecov-io
Copy link

Codecov Report

Merging #43 into master will decrease coverage by 1.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #43      +/-   ##
=========================================
- Coverage    6.90%   5.89%   -1.02%     
=========================================
  Files           6       6              
  Lines         739     730       -9     
=========================================
- Hits           51      43       -8     
+ Misses        670     669       -1     
  Partials       18      18
Impacted Files Coverage Δ
server/command.go 0.00% <0.00%> (ø)
server/configuration.go 25.00% <0.00%> (-3.58%) ⬇️
server/utils.go 43.13% <0.00%> (-0.73%) ⬇️
server/plugin.go 4.31% <0.00%> (-0.43%) ⬇️
server/api.go 0.00% <0.00%> (ø)
server/main.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18ab5d4...ceaf7c1. Read the comment docs.

@nathanaelhoun
Copy link
Contributor Author

Thanks @mickmister for the suggestions, I still need to improve my English!
I have adressed your requests :D

mickmister
mickmister approved these changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@mickmister mickmister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks @nathanaelhoun!

@hanzei hanzei removed the 1: PM Review Requires review by a product manager label Oct 8, 2020
iomodo
iomodo approved these changes Oct 9, 2020
View reviewed changes
Copy link

@iomodo iomodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution @nathanaelhoun !

@hanzei hanzei removed the 2: Dev Review Requires review by a core committer label Oct 9, 2020
@hanzei hanzei requested a review from DHaussermann October 9, 2020 17:25
@hanzei hanzei added this to the v1.2.0 milestone Oct 9, 2020
DHaussermann
DHaussermann approved these changes Oct 15, 2020
View reviewed changes
Copy link

@DHaussermann DHaussermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and paseed

  • Tested all options have been included in auto-complete and are functional
  • Tested that auto-complete options work on mobile
  • No issues found.
    LGTM!

Thanks @nathanaelhoun for adding this improvment!

@DHaussermann DHaussermann added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Oct 15, 2020
@hanzei hanzei merged commit 20876f8 into mattermost-community:master Oct 16, 2020
@nathanaelhoun nathanaelhoun deleted the gh-32-add-autocomplete branch October 16, 2020 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHaussermann DHaussermann DHaussermann approved these changes

@mickmister mickmister mickmister approved these changes

@iomodo iomodo iomodo approved these changes

@aaronrothschild aaronrothschild aaronrothschild approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Hacktoberfest hacktoberfest-accepted
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

Add slash command autocomplete functionality
9 participants
@nathanaelhoun @mattermod @codecov-io @aaronrothschild @iomodo @mickmister @DHaussermann @jasonblais @hanzei