Help displayed on invalid jenkins slash command #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanzei
added
2: Dev Review
Codecov Report
@@ Coverage Diff @@
## master #40 +/- ##
=========================================
- Coverage 6.93% 6.91% -0.03%
=========================================
Files 6 6
Lines 735 738 +3
=========================================
Hits 51 51
- Misses 666 669 +3
Partials 18 18
Continue to review full report at Codecov.
|
hanzei
approved these changes
Jul 8, 2020
levb
approved these changes
Jul 16, 2020
DHaussermann
approved these changes
Jul 23, 2020
There was a problem hiding this comment.
Tested and passed
- Invalid commands now show
Unknown Command:<command> - Regression tested valid commands are not affected
- No issues found.
LGTM!
Thanks @abdulsmapara for fixing this!
DHaussermann
added
4: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On invalid jenkins slash command (for eg.
/jenkins run test2as run is not a command), help is displayed to the user.Ticket Link
Fixes #37