Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate GolangCI-Lint #45

Closed
hanzei opened this issue Aug 11, 2020 · 1 comment · Fixed by #46
Closed

Integrate GolangCI-Lint #45

hanzei opened this issue Aug 11, 2020 · 1 comment · Fixed by #46
Assignees
@nathanaelhoun
Labels
Difficulty/2:Medium Medium ticket Good First Issue Suitable for first-time contributors Help Wanted Community help wanted Tech/Go Type/Task A general task

Comments

@hanzei
Copy link
Contributor

hanzei commented Aug 11, 2020

Mattermost is currently in the process of using golangci-lint as the default linter for all go projects. mattermost-community/mattermost-plugin-autolink#108 serves as an example of how the migration should look like:

  1. Copy .golangci.yml from https://github.com/mattermost/mattermost-plugin-autolink/ into this repository.
  2. Copy Makefile from https://github.com/mattermost/mattermost-plugin-autolink/ into this repository.
  3. Copy build/ from https://github.com/mattermost/mattermost-plugin-autolink/ into this repository.
  4. Run go mod tidy and make dist to ensure the build system works fine.
  5. Update linters-settings.goimports.local-prefixes to the go module path i.e. to github.com/mattermost/mattermost-plugin-aws-SNS.
  6. Run make golangci-lint and fix all issues that arise.

Fixing an linter issue is sometimes trivial but can also be quite complicated. There might be cases, where ignoring an issue using issues.exclude-rules is needed. If you don't know how to resolve an error, please reach out to @hanzei on the Mattermost Community Server or ask the question here.
@hanzei hanzei added Help Wanted Community help wanted Up For Grabs Ready for help from the community. Removed when someone volunteers Good First Issue Suitable for first-time contributors Tech/Go Difficulty/2:Medium Medium ticket Type/Task A general task labels Aug 11, 2020
@nathanaelhoun
Copy link
Contributor

I take it!

@nathanaelhoun nathanaelhoun mentioned this issue Aug 11, 2020
Merged
@hanzei hanzei removed the Up For Grabs Ready for help from the community. Removed when someone volunteers label Aug 11, 2020
hanzei pushed a commit that referenced this issue Aug 11, 2020
@nathanaelhoun
#45 - Integrate GolangCI-lint (#46)
ee74269
@larkox larkox mentioned this issue Aug 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nathanaelhoun nathanaelhoun

Labels
Difficulty/2:Medium Medium ticket Good First Issue Suitable for first-time contributors Help Wanted Community help wanted Tech/Go Type/Task A general task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#45 - Integrate GolangCI-lint
2 participants
@hanzei @nathanaelhoun