[GH-31] Allow editing Sub Fields #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
existing subscription
jfrerich
added
1: PM Review
levb
approved these changes
Jul 16, 2020
mickmister
approved these changes
Jul 16, 2020
DHaussermann
approved these changes
Aug 3, 2020
DHaussermann
added
QA Review Done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When editing an existing subscription, via the
/confluence subscribe <name>slash command, the fields were allreadonly. This PR removes prop which allows editing the fields again.I am not sure why this was programmed this way in the first place.
I could see the use case if we wanted to show all users what subscriptions were available, but leave the fields readonly, but that is not of this PR.
@aaronrothschild, I added to to get feedback on if you knew of a good reason to not allow editing subscription fields once after the first save.
Ticket Link
Fixes #31