Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace build-and-release workflow with ci-build #58

Merged
merged 2 commits into from
Jun 1, 2020
Merged

replace build-and-release workflow with ci-build #58

merged 2 commits into from
Jun 1, 2020

Conversation

jfrerich
Copy link
Contributor

Summary

This PR is created to fix the release process for the confluence plugin. In trying to add the plugin to the marketplace, the first point of failure is the /mb cutplugin --tag v1.2.0 --repo mattermost-plugin-confluence command.

image

The failed CircleCi run can be found here
For reference a working release can be found here (welcomebot)

Ticket Link

n/a

@jfrerich jfrerich added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester Work In Progress Not yet ready for review labels May 29, 2020
@jfrerich jfrerich requested review from levb, mickmister and hanzei May 29, 2020 22:09
@jfrerich jfrerich self-assigned this May 29, 2020
@jfrerich
Copy link
Contributor Author

I replaced the entire .circleci/config.yaml file to match the file we use for our other plugins. You can see circleci is now running ci-build instead of build-and-release

@jfrerich
Copy link
Contributor Author

What this change should also accomplish is using our plugin-ci/deploy-release and plugin-ci/depoy-release-github jobs to do a proper release.

@jfrerich jfrerich removed the Work In Progress Not yet ready for review label May 29, 2020
levb
levb reviewed May 30, 2020
View reviewed changes
Copy link
Contributor

@levb levb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not familiar enough with the CI setup; will leave it to the others to review.

mickmister
mickmister approved these changes Jun 1, 2020
View reviewed changes
Copy link
Contributor

@mickmister mickmister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense why this change is needed. LGTM!

@jfrerich
Copy link
Contributor Author

jfrerich commented Jun 1, 2020

@hanzei, do you agree with the changes made will address the failed plugin signing issue? I think the only remaining item to get this to marketplace is to get the signed release, which needed this change.

@jfrerich
Copy link
Contributor Author

jfrerich commented Jun 1, 2020

Per [this conversation], I am merging and attempting another release.

@jfrerich jfrerich merged commit f2599a0 into master Jun 1, 2020
@jfrerich jfrerich deleted the circle-fix branch June 1, 2020 22:06
@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Jun 3, 2020
@hanzei hanzei mentioned this pull request Jun 3, 2020
Merged
@hanzei hanzei added this to the v1.2.0 milestone Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levb levb levb left review comments

@mickmister mickmister mickmister approved these changes

@hanzei hanzei Awaiting requested review from hanzei

Assignees

@jfrerich jfrerich

Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jfrerich @levb @mickmister @hanzei