Change "alias" to "subscription name" in user-facing strings #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snapshot
mickmister
added
2: Dev Review
jfrerich
approved these changes
Apr 28, 2020
|
@mickmister I see the changes when using list and some of the reposes from the plugin where it now says |
|
@DHaussermann Fixed 👍 |
DHaussermann
approved these changes
May 4, 2020
There was a problem hiding this comment.
Tested and passed
Thanks @mickmister This is now resolved as expected. I see the modal change.
LGTM!
DHaussermann
added
4: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes any user-facing strings that mention the word
alias, referring to a subscription's name. I've discussed with @jfrerich the route of renaming theAliasproperty on the subscription toName, but we agreed that just changing the user-facing string is fine. Also, there is already an unrelatedNamemethod on the subscription, used to differentiate between aSpacevsPagesubscription.Ticket Link
Fixes #34