Let subscription name usage in commands be case insensitive #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
support multiple word alias
mickmister
added
2: Dev Review
mickmister
force-pushed
the
case-insensitive-alias
branch
from
f9bd1b8 to
3e340d9
Compare
DHaussermann
approved these changes
May 4, 2020
DHaussermann
added
4: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR lets the user's input for the subscription be used to match an existing subscription, regardless if the name's casing matches the original name's casing. For example if a subscription's name is
Important Topic, the user can type/confluence unsubscribe important topicto delete the subscription./confluence editalso works the same.Another thing fixed here is that the subscription name can be multiple words. Before, neither of these slash commands worked when the subscription's name had multiple words.
Ticket Link
Fixes #35