Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-36011] reference mattermost github repo throughout code, not the authors #29

Merged
merged 2 commits into from
Jun 9, 2021
Merged

[MM-36011] reference mattermost github repo throughout code, not the authors #29

merged 2 commits into from
Jun 9, 2021

Conversation

jfrerich
Copy link
Contributor

@jfrerich jfrerich commented May 26, 2021 •
edited
Loading

Summary

This PR substitutes all github.com/kosgrz/mattermost-plugin-bitbucket imports for github.com/mattermost/mattermost-plugin-bitbucket

Ticket Link

https://mattermost.atlassian.net/browse/MM-36011

resolves #21

@jfrerich jfrerich requested review from larkox and levb May 26, 2021 19:13
@jfrerich jfrerich added the 2: Dev Review Requires review by a core committer label May 26, 2021
@jfrerich jfrerich added this to the v1.1.0 milestone May 26, 2021
@jfrerich jfrerich linked an issue May 26, 2021 that may be closed by this pull request
Will need to s/kosgrz/mattermost/ once the repo is transferred #21
Closed
@jfrerich jfrerich requested a review from hanzei June 4, 2021 17:30
hanzei
hanzei requested changes Jun 4, 2021
View reviewed changes
Copy link
Collaborator

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.golangci.yml need to be updated

@jfrerich jfrerich requested a review from hanzei June 8, 2021 16:43
@jfrerich
Copy link
Contributor Author

jfrerich commented Jun 8, 2021

.golangci.yml need to be updated

Nice catch, @hanzei. Done.

hanzei
hanzei approved these changes Jun 9, 2021
View reviewed changes
Copy link
Collaborator

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Jun 9, 2021
@jfrerich jfrerich merged commit 8c14ea2 into compare Jun 9, 2021
@jfrerich jfrerich deleted the MM-36011-subs-author-with-mattermost branch June 9, 2021 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanzei hanzei hanzei approved these changes

@larkox larkox larkox approved these changes

@levb levb Awaiting requested review from levb

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

Will need to s/kosgrz/mattermost/ once the repo is transferred
3 participants
@jfrerich @larkox @hanzei