Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release Bump 3.2.1 #161

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Release Bump 3.2.1 #161

merged 2 commits into from
Mar 15, 2024

Conversation

raghavaggarwal2308
Copy link
Contributor

@raghavaggarwal2308 raghavaggarwal2308 commented Mar 4, 2024 •
edited
Loading

@raghavaggarwal2308 raghavaggarwal2308 self-assigned this Mar 4, 2024
@AayushChaudhary0001
Copy link

@raghavaggarwal2308 While testing this PR, it was found that the PR for adding whitespacing for the toggle button was not working, please check it once. After that we can proceed with further testing.

@raghavaggarwal2308 raghavaggarwal2308 mentioned this pull request Mar 13, 2024
Merged
@raghavaggarwal2308
Copy link
Contributor Author

@raghavaggarwal2308 While testing this PR, it was found that the PR for adding whitespacing for the toggle button was not working, please check it once. After that we can proceed with further testing.

@AayushChaudhary0001 Fixed here: #162

@mickmister
Copy link
Contributor

/update-branch

@raghavaggarwal2308
Copy link
Contributor Author

@AayushChaudhary0001 The above issue is fixed now

AayushChaudhary0001
AayushChaudhary0001 approved these changes Mar 14, 2024
View reviewed changes
Copy link

@AayushChaudhary0001 AayushChaudhary0001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been tested for the following scenarios:-

  • Fixed the spacing between the toggle button and label.
  • Fixed the allowance of 0 from middle to end.
  • Basic slash commands and features.

The PR was found working fine for the above scenarios, LGTM. Approved.

@mickmister mickmister merged commit 447eb15 into master Mar 15, 2024
@mickmister mickmister deleted the release-bump-3.2.1 branch March 15, 2024 17:38
@raghavaggarwal2308 raghavaggarwal2308 mentioned this pull request Mar 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AayushChaudhary0001 AayushChaudhary0001 AayushChaudhary0001 approved these changes

@mickmister mickmister mickmister approved these changes

Assignees

@raghavaggarwal2308 raghavaggarwal2308

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raghavaggarwal2308 @AayushChaudhary0001 @mickmister